Skip to content

Fix aoe on chameleon pickaxe#23

Merged
LazyFlesh merged 3 commits into
masterfrom
aoefix
Feb 22, 2026
Merged

Fix aoe on chameleon pickaxe#23
LazyFlesh merged 3 commits into
masterfrom
aoefix

Conversation

@LazyFlesh

@LazyFlesh LazyFlesh commented Feb 19, 2026

Copy link
Copy Markdown

Chameleon pickaxe, when enchanted with impact, and therefore mining in an aoe, sometimes failed to do so despite being the effective tool. This can be seen on an attempt to mine tuff or other EFR stone blocks.

Problem is that EFR did not define the harvest tool and harvest level for their stones, which made the ForgeHooks.isToolEffective fail. This adds a backup check based on material.

Added the check to the shovel as well, just in case.

Code is largely inspired by tinkers' hammer and excavator.

Worked in dev env.

some mods don't define the harvest tool *coughefrcough* and the blocks may be skipped even though its the effective tool.
@LazyFlesh LazyFlesh added the Enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Feb 19, 2026
@LazyFlesh
LazyFlesh requested a review from a team February 19, 2026 05:41
Comment thread src/main/java/fox/spiteful/forbidden/items/tools/ItemMorphPickaxe.java Outdated

@sisyphussy sisyphussy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LazyFlesh
LazyFlesh merged commit aed566f into master Feb 22, 2026
1 check passed
@LazyFlesh
LazyFlesh deleted the aoefix branch February 22, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants