fix some issues - #5
Merged
Merged
Conversation
Windorain
marked this pull request as draft
June 8, 2026 11:59
…eries, auto-detect numericX
<br> without trailing slash was parsed as a non-self-closing JSX tag, causing subsequent text to be nested as children and dropped by BreakCompiler. Added void element auto-self-close in MdxMdastExtension and a defensive children compile in BreakCompiler.
- Add scrollY to GuideNavBarState for restoring sidebar scroll position - Replace single-slot lastContentViewState with browser-style linear page history - Remove local history stacks from GuideScreen, delegate to NavigationState - G hotkey now returns to the active page (at pageHistoryIndex), not always the last entry - Back/forward button state and scroll position survive screen close/reopen - Fix navbar expanded state recall by passing correct guideId
… remount Framework (ScriptContextImpl): - Add inheritUid() to auto-copy UID from old node to replacement node in ctx.replace(), ensuring cache key continuity across node swaps Scripts (6 scripts fixed, all had missing ctx.replace()): - ItemLinkScript: add ctx.replace(link) in success path, add fallback branch for already-materialized LytFlowContent nodes, make appendIconAndFallbackText idempotent with removeExistingIcons() - CommandLinkScript: add ctx.replace(link) after setClickCallback - SoundLinkScript: add ctx.replace(link) after setClickSoundSpec - KeyBindScript: add ctx.replace(placeholder) after setText - PlayerNameScript: add ctx.replace(placeholder) after setText - TooltipScript: add ctx.replace(span) after dispatchSubtree Diagnostic logging added in LytHost and ScriptContextImpl for ItemLink cache tracing (uid allocation, cache hit/miss, recordResult).
Windorain
marked this pull request as ready for review
June 10, 2026 13:57
ABKQPO
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.