Improve interaction between locked drawers and dynamic item responder chip#75
Conversation
spacebuilder2020
left a comment
There was a problem hiding this comment.
Looks fine to me. Make sure this is tested and approved by a tester though since I can't review on the interaction portion but at a glance, this seems like a good change that will fix a specific bug.
|
@Dragovorn is there a reason you are doing an inline method instead of overriding the hasItem method? I was looking into the source of the code and notice this other class extending InvWrapper that is overriding the hasItem method. |
|
I was avoiding making a change that was too sweeping because I was afraid of unintended side-effects. |
|
Alright, that was what I figured, thanks for confirming |
|
Having trouble replicating issue, tested with new build and an older build (4.12.27) and both builds route cobblestone to the drawer with 0 items in it. Might be possible that this merged PR has an effect. |
|
Oh thanks for digging that up; that makes sense, I built this patch a little bit ago against v4.11.12. I was getting ready to update my singleplayer so I was making sure to submit all the patches I was playing with at the time. Sorry for taking your time! |
|
No worries, it probably still is a good patch for other elements like jabba barrels, not just this specific bug, so I will test with it more |
|
Going to keep an eye on this. This change is probably benign but I am slightly concerned about bypassing the |
When a locked drawer has an item type assigned to it but is otherwise empty (e.g. locked to cobblestone, but storing 0 cobblestone) the dynamic item responder chip will not route items into it. This PR fixes that and will allow the dynamic item responder to accept any item that it detects is within the inventory.
Reproduction Steps: