Skip to content

Fix ProjectRed wires not providing redstone power#82

Merged
Dream-Master merged 1 commit into
masterfrom
fix/Fix-ProjectRed-wires-not-providing-redstone-power
May 10, 2026
Merged

Fix ProjectRed wires not providing redstone power#82
Dream-Master merged 1 commit into
masterfrom
fix/Fix-ProjectRed-wires-not-providing-redstone-power

Conversation

@Luca-Guettinger
Copy link
Copy Markdown

@Luca-Guettinger Luca-Guettinger commented May 10, 2026

fixes GTNewHorizons/GT-New-Horizons-Modpack#24634
fixes GTNewHorizons/GT-New-Horizons-Modpack#24592

rwConnectable is a ThreadLocal that was only initialized on the client thread. The server thread got false by default, causing canConnectRedstone() to always return false, so wires never provided power. The fix uses initialValue() to ensure every thread gets true as the default.

@Luca-Guettinger Luca-Guettinger requested a review from a team May 10, 2026 15:13
Copy link
Copy Markdown

@DarkShadow44 DarkShadow44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thank you! Looks good, pretty hard bug to spot though - seems like this logic was broken for a long time.

FWIW, easiest way to test is to

  • Open SP world, test the issue (might not happen)
  • Close SP world
  • Open SP world again, test the issue (should happen now)

@Dream-Master Dream-Master merged commit 84b44f4 into master May 10, 2026
1 check passed
@Dream-Master Dream-Master deleted the fix/Fix-ProjectRed-wires-not-providing-redstone-power branch May 10, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project Red Wires Bot Functioning Red alloy wire no longer triggers machines or redstone lamp.

3 participants