Skip to content

Fix several bugs - #134

Merged
cubefury merged 1 commit into
masterfrom
fix-bug
May 29, 2026
Merged

Fix several bugs#134
cubefury merged 1 commit into
masterfrom
fix-bug

Conversation

@cubefury

@cubefury cubefury commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Fixes all of the following:

  1. Fix Vending Machine coins enter ghost state when inputting coins too quickly GT-New-Horizons-Modpack#24920 we need to consume the coins on both client and server, then forcesync all input slots from server-side for each inventory change event. Sync is for all input slots since when items are shiftclick+dragged in, a player can easily send in more than one stack per tick, causing ghost stacks to appear in the next free slot.
  2. Fix Cannot buy items in Vending Machine that require additional items besides coins GT-New-Horizons-Modpack#24938 When the required item was present, it previously added the same item to the missing items list but with stacksize 0. Then when we checked if missing items list was empty, it would fail. This is fixed.
  3. Short delay after putting items in before UI would update. This is because a sync was not scheduled for the next tick after the input slots changed. This is also fixed.
  4. GTNHTeam ID missing for player clientside causing some warning messages to appear when opening the UI. This is because the synchandlers and coinvalue init referenced getTeamByPlayer on the client side. Also fixed.
  5. Fixed bug where items were not consumed from input slots correctly. This is because I set the requiredItem count to 0, then deducted the count from the input slot amount, instead of the other way round. Also fixed.

Tested Daily 541 SP + MP.

@cubefury
cubefury requested a review from a team May 29, 2026 18:42
@cubefury
cubefury merged commit b855842 into master May 29, 2026
1 check passed
@cubefury
cubefury deleted the fix-bug branch May 29, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants