Skip to content

Support non consumable items - #29

Merged
FrostyFire1 merged 4 commits into
masterfrom
support-non-consumables
Oct 17, 2025
Merged

Support non consumable items#29
FrostyFire1 merged 4 commits into
masterfrom
support-non-consumables

Conversation

@cubefury

@cubefury cubefury commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator

The original trade quests had non-consumable items in some of the trades, eg. spawn egg trading. This PR aims to restore this behaviour.

image

No merge until checklist complete:

  • Update trades database with NC items in coremod
  • Test with ME Vending Uplink

@cubefury
cubefury marked this pull request as draft October 15, 2025 18:52
@cubefury
cubefury marked this pull request as ready for review October 16, 2025 18:19
@cubefury
cubefury requested a review from a team October 17, 2025 05:48
@cubefury
cubefury marked this pull request as draft October 17, 2025 09:15
@cubefury

Copy link
Copy Markdown
Collaborator Author

No merge until #31 + rebase

@Dream-Master
Dream-Master marked this pull request as ready for review October 17, 2025 15:05
@Dream-Master
Dream-Master force-pushed the support-non-consumables branch from 1d1ad17 to d9d70d6 Compare October 17, 2025 15:08

@FrostyFire1 FrostyFire1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine

@FrostyFire1
FrostyFire1 merged commit bde3c89 into master Oct 17, 2025
1 check passed
@FrostyFire1
FrostyFire1 deleted the support-non-consumables branch October 17, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants