Fix Prospector's Log packet size overflow - #73
Merged
Conversation
Dream-Master
added
the
🚧 Testing on Zeta
wlhlm
force-pushed
the
prospection-sharing-packet-size-fix
branch
from
October 14, 2025 20:50
cc59ba1 to
72d5458
Compare
glektarssza
reviewed
Oct 26, 2025
glektarssza
left a comment
glektarssza
left a comment
Member
There was a problem hiding this comment.
Code looks sane. I'll give it a build in the morning and test before approving since it's almost midnight.
Member
|
Testing this fix on my private server now. |
glektarssza
approved these changes
Oct 27, 2025
glektarssza
left a comment
glektarssza
left a comment
Member
There was a problem hiding this comment.
Took some tinkering with mod versions to get the mod running on my private server for testing since I'm a bit behind nightly right now but it is working fine now.
Approved.
Dream-Master
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for splitting prospecting data across multiple packets failed to account for the variable length orevein name string.
fallout from #57
fixes GTNewHorizons/GT-New-Horizons-Modpack#18377