Skip to content

Add compatibility with EndlessIds to redo server cache command - #84

Merged
Algent merged 2 commits into
GTNewHorizons:masterfrom
assusdan:master
May 25, 2026
Merged

Add compatibility with EndlessIds to redo server cache command#84
Algent merged 2 commits into
GTNewHorizons:masterfrom
assusdan:master

Conversation

@assusdan

Copy link
Copy Markdown

Some (newly?) generated worlds do not have TileEntity ores, but also do not have NotEnoughIds installed, only EndlessIds.

For this worlds, current redo server cache implementation do not find any ores, as PartiallyLoadedChunk::load misidentifies them as only containing TileEntity ores, which is not true. So, no ores are actually added to cache and saved.

Implemented EndlessIds path to extract block ids and metadata, tested on the world with described behaviour.

@Algent Algent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just added into the org so I guess I'll try a review.

I'll first say that it work well in game.

Someone in discord shared the sources last night and it may be useful files for you:
https://github.com/GTMEGA/EndlessIDs/blob/master/src/main/java/com/falsepattern/endlessids/managers/BlockIDManager.java
https://github.com/GTMEGA/EndlessIDs/blob/master/src/main/java/com/falsepattern/endlessids/managers/BlockMetaManager.java

One thing of note is Block IDs side got a potential extra key "BlocksB3". Probably won't be reached anytime soon but would you mind adding it ? Not necessary to merge but would be nice.

More importantly the NotEnoughIds have a bunch of data corruption check, is it possible to add some similar guards in this new code ?

@Algent

Algent commented May 25, 2026

Copy link
Copy Markdown

I'll merge and take a look at it.

I had been trying to improve rescan on my side but this PR is severely needed first, right now we just get zero hit on rescan on converted data

@Algent
Algent enabled auto-merge (squash) May 25, 2026 18:41
@Algent
Algent merged commit 441d288 into GTNewHorizons:master May 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants