Constrain User api response#878
Merged
Merged
Conversation
This reverts commit 4454183.
plouka13
approved these changes
Jul 15, 2026
plouka13
left a comment
plouka13
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Tested and seems to be working great.
| @@ -1,5 +1,7 @@ | |||
| import { User } from '@prisma/client' | |||
|
|
|||
| export type UserResponse = Omit<User, 'password' | 'emailHash'> | |||
Contributor
There was a problem hiding this comment.
I wonder if there could be a better name rather than UserResponse. My immediate thought when reading UserResponse was the response object for the API when calling GET /user. Although I understand the intention here now that I read over it. No action required because I don't know a good resolution 😆
Contributor
Author
There was a problem hiding this comment.
Yeah - naming things is hard. Happy to modify if you think of a better name.
| ResetPasswordRequest, | ||
| } from 'common/types/api/users' | ||
| import { User } from '@prisma/client' | ||
| // import { User } from '@prisma/client' |
Contributor
Author
|
Forgot to mention that you may need to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use response contains the whole User model, but not all info should be included.
This PR resolves #877 by:
omitkeyword (more terse than usingselect)