Replace stale ctrl-next references left over from repo rename - #934
Merged
Conversation
ignatiusm
approved these changes
Aug 17, 2026
ignatiusm
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this @iamtanuj18 . Looks good to me 🚀
Can you please also create an issue to do the same for the ctrl-docs site sometime? I suspect there may be traces of -next there too: https://github.com/search?q=repo%3AGarvan-Data-Science-Platform%2Fctrl-docs+ctrl-next&type=code
Nice work tidying up around the place!
Author
|
Thanks for the review @ignatiusm! I've merged the PR to I've also created a follow-up issue on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #913.
The repo was renamed from
ctrl-nexttoctrlat some point, and stale references were left behind in three files. Docker prefixes volume names with the project directory name, so the actual volume isctrl_ctrl-db(confirmed viadocker volume ls), but the Makefile was still trying to removectrl-next_ctrl-db, which is whymake cleanfailed withno such volume.Per @plouka13's follow-up comment on the issue ("should look for any other stale content in ctrl around
ctrl-next"), I did a broader sweep with ripgrep. Eight stale references across three files:Replaced all
ctrl-nextwithctrlin place across those three files. After the fix,rg "ctrl-next" .returns no matches. Also verifiedmake cleannow runs end-to-end without the volume error.