More universal location for dot org assets, allows local assets folder

[afragen]

Now uses /.wordpress-org as location for dot org assets. Since 10up has created the GitHub Action for similar purposes, it seems this naming structure will be better.
Fixes https://github.com/GaryJones/wordpress-plugin-svn-deploy/issues/31

[GaryJones]

The readme would also need updating.

Also, how about asking the user what the directory name is of their asserts directory, perhaps defaulting to .wordpress-org? (If so, another step in the readme would be needed).

[afragen]

I just updated the README. I also bumped the version as this would be a breaking change.

I think we should commit to a standard, with respect to the location of the dot org assets.

I don't believe we need to provide an option for the user to name their own repo folder containing objects that would need updating to SVN /assets. Decsions, not options. Besides this would allow users more flexibility to switch to the GitHub Actions or back without needing to further modify their repo.

[GaryJones]

I think we should commit to a standard, with respect to the location of the dot org assets.

But, there is no standard.

• https://github.com/johnbillion/grunt-wp-deploy has wp-assets as the default directory name.
• But https://github.com/johnbillion/query-monitor (by the same author!) uses assets-wp-repo.
• https://github.com/rayrutjes/wp-plugin-git-svn-sync#custom-assets-directory expects .wordpress.org
• https://git.ethitter.com/open-source/wp-org-plugin-deploy uses .wordpress-org by default (it's based off of 10up's GH Action), but still allows it to be overridden with an environment variable.
• Anyone using this script (or a predecessor / fork) will be using assets, and any change to this script shouldn't be forcing changes on multiple plugin repos just so they can continue using it.

The decision we make, is setting the default value. For any new users, that shows the intent, which I'm happy to follow. For any existing users who update to the major version, then being prompted allows them a quick way of still getting their deployment done without having to stop and start renaming their directory.

[afragen]

I didn't mean to imply that .wordpress-org was a standard. I only meant to imply that it's now being touted by @10up with their GitHub Action and it's seems as good as anything.

That and we have at least one issue with a user wanting to have an assets dir in their plugin. #31

It seems much more reasonable to default to something that isn't likely to be used for anything else, but I can certainly add a setting ask with .wordpress-org as default. I don't really think we/I took very much consideration into using the exact same name as on SVN. 🤦‍♂

[afragen]

@GaryJones Any thoughts as to which step number this should be?

I'm thinking it's a new step 3

[GaryJones]

I'd say a new Q3 (after the current step 3, which is checking that the current Q2 is valid).

[afragen]

How does this look? Seems to test out fine in a quick run without actual svn commit

[afragen]

I took out the linting updates as it distorted what we want to accomplish.

[GaryJones]

Looks like we need a 3.1.0 tag before you tag a 4.0.0 ;-)

[afragen]

So a 3.1.0 tag off the current develop branch?

I haven’t really tagged releases here just sort of bumped the occasional version number. 😉

Happy Christmas 🎄

[GaryJones]

Well, on those commits where you bumped the version, tag (oldest first) and push those tags, before doing 4.0 :-)