ci(test): install docker SDK so CI runs the full suite (fix red main)#115
Conversation
…from cm6 floor) The test job installed only requirements.txt + a short list, omitting the 'docker' SDK that orchestrator/worker_api tests import. So CI silently failed to collect ~196 Docker-SDK tests (962 of 1158) and reported ~82% coverage instead of the real ~94%. That surfaced when CashPilot-cm6 added --cov-fail-under=90 (which correctly failed at 81.65%). Installing docker makes CI collect the full suite, so the floor now reflects reality and passes.
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 93.70% 93.80% +0.09%
==========================================
Files 31 33 +2
Lines 3337 3858 +521
==========================================
+ Hits 3127 3619 +492
- Misses 210 239 +29 🚀 New features to boost your workflow:
|
Hotfix for main (went red after #114). Root cause: the CI
testjob installedrequirements.txt+ a short pip list that omitted thedockerSDK. Every test module thatimport docker(orchestrator, worker_api, worker_resources) failed to collect, so CI silently ran 962 of 1158 tests and reported 81.65% coverage instead of the real ~94%. When #114 added--cov-fail-under=90, that correctly failed — exposing a long-standing gap where CI never ran the Docker-SDK tests.Fix: add
dockerto the test install so CI collects the full suite; the 90% floor now reflects reality. One-line change.