Skip to content

ci(test): install docker SDK so CI runs the full suite (fix red main)#115

Merged
GeiserX merged 1 commit into
mainfrom
fix/loop-cm6-coverage-floor-hotfix
Jul 18, 2026
Merged

ci(test): install docker SDK so CI runs the full suite (fix red main)#115
GeiserX merged 1 commit into
mainfrom
fix/loop-cm6-coverage-floor-hotfix

Conversation

@GeiserX

@GeiserX GeiserX commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Hotfix for main (went red after #114). Root cause: the CI test job installed requirements.txt + a short pip list that omitted the docker SDK. Every test module that import docker (orchestrator, worker_api, worker_resources) failed to collect, so CI silently ran 962 of 1158 tests and reported 81.65% coverage instead of the real ~94%. When #114 added --cov-fail-under=90, that correctly failed — exposing a long-standing gap where CI never ran the Docker-SDK tests.

Fix: add docker to the test install so CI collects the full suite; the 90% floor now reflects reality. One-line change.

…from cm6 floor)

The test job installed only requirements.txt + a short list, omitting the 'docker'
SDK that orchestrator/worker_api tests import. So CI silently failed to collect ~196
Docker-SDK tests (962 of 1158) and reported ~82% coverage instead of the real ~94%.
That surfaced when CashPilot-cm6 added --cov-fail-under=90 (which correctly failed at
81.65%). Installing docker makes CI collect the full suite, so the floor now reflects
reality and passes.
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@GeiserX, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f7606b1e-d874-4aba-9175-8ec9665572e8

📥 Commits

Reviewing files that changed from the base of the PR and between 5d55c60 and 5ab1818.

📒 Files selected for processing (1)
  • .github/workflows/test.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/loop-cm6-coverage-floor-hotfix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.80%. Comparing base (63c0675) to head (5ab1818).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   93.70%   93.80%   +0.09%     
==========================================
  Files          31       33       +2     
  Lines        3337     3858     +521     
==========================================
+ Hits         3127     3619     +492     
- Misses        210      239      +29     

see 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GeiserX
GeiserX merged commit 373fa59 into main Jul 18, 2026
8 checks passed
@GeiserX
GeiserX deleted the fix/loop-cm6-coverage-floor-hotfix branch July 18, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant