fix: stop publishing agent working files on the public docs site - #241
Merged
Conversation
MkDocs builds every file in docs_dir whether or not it appears in nav, so three agent scratch files were live on the public site despite being in no menu: https://geiserx.github.io/CashPilot/GOAL/ -> HTTP 200 https://geiserx.github.io/CashPilot/AUTOPILOT-WORKLOG/ -> HTTP 200 Between them they published this project's internal planning verbatim, quoted the maintainer directly, and printed a real Mysterium node identity address, which links this public repository to a specific earning node. `mkdocs build --strict` does NOT catch this. validation.nav.omitted_files defaults to `info` and --strict only promotes `warn` to an error, so the orphans are reported and the build stays green. Exclusion has to be explicit. Verified by building the site: 64 pages, all three excluded, homepage and guides intact. Removing the block makes all three reappear.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe change removes agent working documents, ignores related files, excludes them from MkDocs output, and adds tests for publication, Git tracking, and exclusion documentation. ChangesAgent artifact controls
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Excluding them from the built site stopped the publication; it left them tracked, so the next agent run would commit fresh content straight back into a public repository. docs/GOAL.md and docs/AUTOPILOT-WORKLOG.md are now untracked (kept on disk) and all three are gitignored. The guard covers both directions: excluded from the site AND absent from the index. NOTE, and it is not solved by this commit: both files have been tracked since e631e3a, so their content -- including a real Mysterium node identity address -- is in this public repository's HISTORY. Untracking stops it growing. Removing what is already there needs a history rewrite, which is the maintainer's call.
GeiserX
added a commit
that referenced
this pull request
Aug 5, 2026
* fix: stop publishing agent working files on the public docs site MkDocs builds every file in docs_dir whether or not it appears in nav, so three agent scratch files were live on the public site despite being in no menu: https://geiserx.github.io/CashPilot/GOAL/ -> HTTP 200 https://geiserx.github.io/CashPilot/AUTOPILOT-WORKLOG/ -> HTTP 200 Between them they published this project's internal planning verbatim, quoted the maintainer directly, and printed a real Mysterium node identity address, which links this public repository to a specific earning node. `mkdocs build --strict` does NOT catch this. validation.nav.omitted_files defaults to `info` and --strict only promotes `warn` to an error, so the orphans are reported and the build stays green. Exclusion has to be explicit. Verified by building the site: 64 pages, all three excluded, homepage and guides intact. Removing the block makes all three reappear. * fix: never commit the agent working files either Excluding them from the built site stopped the publication; it left them tracked, so the next agent run would commit fresh content straight back into a public repository. docs/GOAL.md and docs/AUTOPILOT-WORKLOG.md are now untracked (kept on disk) and all three are gitignored. The guard covers both directions: excluded from the site AND absent from the index. NOTE, and it is not solved by this commit: both files have been tracked since 607b19b, so their content -- including a real Mysterium node identity address -- is in this public repository's HISTORY. Untracking stops it growing. Removing what is already there needs a history rewrite, which is the maintainer's call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while researching the docs-navigation bead. This is live right now, which is why it is a fix rather than a bead.
What is public today
MkDocs builds every file in
docs_dir, whether or not it appears innav. Three agent scratch files sat there, so they were published:Neither appears in any menu. Between them they publish:
0x55fd…), which links this public repository to a specific earning nodeThat last one is the reason I did not just file this: an on-chain identity is not a secret, but publishing it next to the repo that describes the fleet it belongs to is a linkage that did not exist before.
It also contradicts the project's own documentation rule, that docs state intent rather than quoting or attributing what any person said.
Why
--strictwould not have saved usThis is the counterintuitive part and worth recording. MkDocs reports the orphans — but at
INFO:validation.nav.omitted_filesdefaults toinfo, and--strictonly promoteswarnto an error. So a--strictbuild stays green with these published. Exclusion has to be explicit.(Note what else that output reveals:
guides/proxybase-xyz.mdis orphaned too — and the catalog marks that service active. Tracked separately in the docs-nav bead.)The change
An
exclude_docsblock, with the reasoning recorded beside it so a later tidy-up does not delete it as unexplained.Evidence
Built the site for real (mkdocs 1.6.1, from
docs/requirements-docs.txt):GOAL,AUTOPILOT-WORKLOG,DEFERRED-QUESTIONSgetting-started,guides/honeygainNegative control: removing the
exclude_docsblock and rebuilding makes all three reappear in the output — so the block is what is doing the work, not an accident of the build.9 regression tests. The guard is not "these three names are listed" — it also fails for any new agent-looking file dropped into
docs/(*WORKLOG*,*-STATE,NOTES, …), so the next one is caught rather than published. Removing the block fails all 9.Gates:
ruffclean, 3287 passed, 95.44% coverage.Not done here, deliberately
The files are excluded from the site, not deleted from the repo — that is a separate decision about whether agent artifacts belong in
docs/at all, and deleting content is not something to do quietly inside a publishing fix.Summary by CodeRabbit