Skip to content

fix(brand): one official mark, with the sun touching all four edges - #288

Merged
GeiserX merged 1 commit into
mainfrom
fix/logo-sun-touches-the-edges
Aug 7, 2026
Merged

fix(brand): one official mark, with the sun touching all four edges#288
GeiserX merged 1 commit into
mainfrom
fix/logo-sun-touches-the-edges

Conversation

@GeiserX

@GeiserX GeiserX commented Aug 7, 2026

Copy link
Copy Markdown
Owner

The sun sat in a 192×192 box inside a 256 canvas — 32px of padding left and right, 36 top — so the mark read as something small floating in space wherever it was placed.

Measured rather than eyeballed. Rendering and trimming gave 192x192 at +32+36; it now gives 256x256 at +0+0 — touching, never overflowing.

Scaled about the disc's own centre (r 96 → 128, and up 4px because the sun sat at cy=132) rather than re-deriving every band and the plane by hand, so the artwork is exactly as drawn.

One mark everywhere

There were three different drawings before: logo.svg (transparent, r=96), icon.svg + images/icon.svg (a dark rounded plate with an even smaller r=72 sun), and a hand-tuned 32px favicon (r=11). All four files are now byte-identical.

Two things I got wrong, both caught by rendering rather than reading

  • I had claimed logo.svg carried a white background and rejected it for the Heimdall tile on that basis. It does not — that white rect is inside a <mask>, so it is never painted. Its top-left pixel is srgba(0,0,0,0), mean alpha 0.35. That rejection was wrong; the Heimdall submission is corrected separately.
  • My first favicon attempt scaled its artwork the same way. Also wrong: the bands and plane were hand-sized for 32px, so enlarging the disc made the plane dominate and break out of the circle. Rendered at a real 32px the canonical mark beats both it and the original, so the separate drawing is retired.

Verified: all four parse as XML, all four measure full-bleed at their own size, mkdocs --strict builds, 4370 tests pass.

The sun sat in a 192x192 box inside a 256 canvas -- 32px of padding left and
right, 36 top -- so the mark read as something small floating in space wherever
it was placed. Measured, not eyeballed: rendering and trimming gave
"192x192 at +32+36". It now gives "256x256 at +0+0" -- touching, never
overflowing.

Done by scaling the whole mark about the disc's own centre (r 96 to 128, and up
4px because the sun sat at cy=132) rather than re-deriving every band and the
plane by hand, so the artwork is exactly as drawn.

ONE MARK EVERYWHERE, which is the other half of the request. There were three
different drawings before: logo.svg (transparent, r=96), icon.svg and
images/icon.svg (a dark rounded plate with an even smaller r=72 sun), and a
hand-tuned 32px favicon (r=11). All four files are now byte-identical.

TWO THINGS I GOT WRONG ON THE WAY, both caught by rendering rather than reading:

  * I had claimed logo.svg carried a white background and rejected it for the
    Heimdall tile on that basis. It does not: that white rect is inside a
    <mask>, so it is never painted. Verified -- its top-left pixel is
    srgba(0,0,0,0) and mean alpha is 0.35. That rejection was wrong and the
    Heimdall submission is corrected separately.

  * My first favicon attempt scaled ITS artwork by the same trick. That was
    wrong: the bands and plane were hand-sized for 32px, so enlarging the disc
    made the plane dominate and break out of the circle. Rendered at a real
    32px the canonical mark beats both it and the original -- bands still read,
    the plane stays a silhouette -- so the separate drawing is retired.

Verified: all four parse as XML, all four measure full-bleed at their own size,
mkdocs --strict builds, 4370 tests pass.
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • app/static/favicon.svg is excluded by !**/*.svg
  • docs/icon.svg is excluded by !**/*.svg
  • docs/images/icon.png is excluded by !**/*.png
  • docs/images/icon.svg is excluded by !**/*.svg
  • docs/logo.svg is excluded by !**/*.svg

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e97ffd8b-3421-4344-943f-3efdd5f52182

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GeiserX
GeiserX merged commit 7fc561e into main Aug 7, 2026
7 checks passed
@GeiserX
GeiserX deleted the fix/logo-sun-touches-the-edges branch August 7, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant