test: dividend + double taxation coverage, strict ESLint#7
Conversation
- 13 new tests: dividends (7), double taxation (6) — covers parseDate in dividends.ts, withholding matching, PILDs, progressive savings brackets, country aggregation - ESLint upgraded to strictTypeChecked with tsconfig.eslint.json for test inclusion; parser any suppressed, web void suppressed - Total: 39 tests across 6 test files, all passing - ESLint: 0 errors, 0 warnings
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 28 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 32.42% 41.11% +8.69%
==========================================
Files 16 16
Lines 953 951 -2
Branches 121 136 +15
==========================================
+ Hits 309 391 +82
+ Misses 642 558 -84
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Custom SVG banner with tax/finance theme (dark slate, red/amber Spanish accent, mini gain/loss charts, casilla boxes) - README header: centered banner, title, tagline, flat-square badges (license, codecov, CI, stars, awesome-spain)
* test: add dividend + double taxation tests, strict ESLint config - 13 new tests: dividends (7), double taxation (6) — covers parseDate in dividends.ts, withholding matching, PILDs, progressive savings brackets, country aggregation - ESLint upgraded to strictTypeChecked with tsconfig.eslint.json for test inclusion; parser any suppressed, web void suppressed - Total: 39 tests across 6 test files, all passing - ESLint: 0 errors, 0 warnings * docs: add project banner SVG and update README header - Custom SVG banner with tax/finance theme (dark slate, red/amber Spanish accent, mini gain/loss charts, casilla boxes) - README header: centered banner, title, tagline, flat-square badges (license, codecov, CI, stars, awesome-spain)
Summary
parseDategap flagged by Codecov, withholding tax matching, Payment In Lieu, progressive savings brackets, country aggregationstrictTypeCheckedwith dedicatedtsconfig.eslint.jsonfor test inclusionanysuppressed (XML parsing is inherently untyped), web void/promises suppressedTest plan
src/engine/dividends.tsparseDate lines flagged by Codecov