Skip to content

test: dividend + double taxation coverage, strict ESLint#7

Merged
GeiserX merged 2 commits into
mainfrom
feat/phase-1-coverage-eslint
Apr 14, 2026
Merged

test: dividend + double taxation coverage, strict ESLint#7
GeiserX merged 2 commits into
mainfrom
feat/phase-1-coverage-eslint

Conversation

@GeiserX

@GeiserX GeiserX commented Apr 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • 13 new tests (26 → 39 total): dividends (7) and double taxation (6) — covers the parseDate gap flagged by Codecov, withholding tax matching, Payment In Lieu, progressive savings brackets, country aggregation
  • ESLint upgraded to strictTypeChecked with dedicated tsconfig.eslint.json for test inclusion
  • Parser any suppressed (XML parsing is inherently untyped), web void/promises suppressed

Test plan

  • 39 tests pass across 6 test files
  • TypeScript typecheck clean
  • ESLint: 0 errors, 0 warnings
  • Covers src/engine/dividends.ts parseDate lines flagged by Codecov

- 13 new tests: dividends (7), double taxation (6) — covers
  parseDate in dividends.ts, withholding matching, PILDs,
  progressive savings brackets, country aggregation
- ESLint upgraded to strictTypeChecked with tsconfig.eslint.json
  for test inclusion; parser any suppressed, web void suppressed
- Total: 39 tests across 6 test files, all passing
- ESLint: 0 errors, 0 warnings
@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@GeiserX has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 28 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 28 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 69f7d2e3-3ba6-4be4-a775-99b739085af3

📥 Commits

Reviewing files that changed from the base of the PR and between 7c89e92 and a63199a.

⛔ Files ignored due to path filters (1)
  • docs/images/banner.svg is excluded by !**/*.svg
📒 Files selected for processing (5)
  • README.md
  • eslint.config.js
  • tests/engine/dividends.test.ts
  • tests/engine/double-taxation.test.ts
  • tsconfig.eslint.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/phase-1-coverage-eslint

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter

codecov-commenter commented Apr 14, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.11%. Comparing base (7c89e92) to head (a63199a).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   32.42%   41.11%   +8.69%     
==========================================
  Files          16       16              
  Lines         953      951       -2     
  Branches      121      136      +15     
==========================================
+ Hits          309      391      +82     
+ Misses        642      558      -84     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Custom SVG banner with tax/finance theme (dark slate, red/amber
  Spanish accent, mini gain/loss charts, casilla boxes)
- README header: centered banner, title, tagline, flat-square badges
  (license, codecov, CI, stars, awesome-spain)
@GeiserX
GeiserX merged commit e5810af into main Apr 14, 2026
4 checks passed
@GeiserX
GeiserX deleted the feat/phase-1-coverage-eslint branch April 14, 2026 12:03
GeiserX added a commit that referenced this pull request Apr 15, 2026
* test: add dividend + double taxation tests, strict ESLint config

- 13 new tests: dividends (7), double taxation (6) — covers
  parseDate in dividends.ts, withholding matching, PILDs,
  progressive savings brackets, country aggregation
- ESLint upgraded to strictTypeChecked with tsconfig.eslint.json
  for test inclusion; parser any suppressed, web void suppressed
- Total: 39 tests across 6 test files, all passing
- ESLint: 0 errors, 0 warnings

* docs: add project banner SVG and update README header

- Custom SVG banner with tax/finance theme (dark slate, red/amber
  Spanish accent, mini gain/loss charts, casilla boxes)
- README header: centered banner, title, tagline, flat-square badges
  (license, codecov, CI, stars, awesome-spain)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants