Fix DiffPipeline.ApplyPatch: handle differs that do internal atomic replacement - #274
Merged
Conversation
…eaves tempPath intact (BinaryHandler already handles it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix DiffPipeline.ApplyPatch to correctly handle IBinaryDiffer implementations that perform atomic file replacement internally (e.g., BinaryHandler).
Bug
BinaryHandler.DirtyAsync already does: delete old file, copy temp to old, delete temp. After it returns, tempPath no longer exists. DiffPipeline.ApplyPatch then:
Fix
ApplyPatch now checks if tempPath still exists after DirtyAsync: