Skip to content

Add basic macOS driver updater implementation #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JusterZhu merged 1 commit into from
May 23, 2026
Merged

Add basic macOS driver updater implementation #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/c#/GeneralUpdate.Drivelution/Core/DriverUpdaterFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ public static IGeneralDrivelution Create(DrivelutionOptions? options = null)
}
else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
{
GeneralTracer.Warn("MacOS platform detected but not yet implemented");
throw new PlatformNotSupportedException(
"MacOS driver update is not yet implemented. " +
"This is a placeholder for future MacOS support. " +
"Current platform: macOS");
GeneralTracer.Info("Detected macOS platform, creating MacOsGeneralDrivelution");
var validator = new MacOSDriverValidator();
var backup = new MacOSDriverBackup();
var commandRunner = new CommandRunner();
return new MacOsGeneralDrivelution(validator, backup, commandRunner, options);
}
else
{
Expand Down Expand Up @@ -134,7 +134,7 @@ public static string GetCurrentPlatform()
public static bool IsPlatformSupported()
{
return RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ||
RuntimeInformation.IsOSPlatform(OSPlatform.Linux);
// MacOS is planned but not yet implemented
RuntimeInformation.IsOSPlatform(OSPlatform.Linux) ||
RuntimeInformation.IsOSPlatform(OSPlatform.OSX);
}
}
Loading
Loading