Skip to content

fix: Fix game hang when taking screenshots - #528

Merged
x64-dev merged 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
MrS-ibra:fix/screenshot-pDXsurf-release
Jul 29, 2026
Merged

fix: Fix game hang when taking screenshots#528
x64-dev merged 1 commit into
GeneralsOnlineDevelopmentTeam:mainfrom
MrS-ibra:fix/screenshot-pDXsurf-release

Conversation

@MrS-ibra

@MrS-ibra MrS-ibra commented Jun 27, 2026

Copy link
Copy Markdown

Fixes game hang when capturing screenshots, that includes pressing F11 to take the screenshot or game capturing screenshots on load screen and in game for meta data.
pDXsurf was being released on the worker thread where it was contending with the main thread over D3D's internal lock during resource destruction,. It is now only cleaned up on the main thread alongside the other surface cleanup regardless of bSucceeded

@x64-dev
x64-dev merged commit 283878d into GeneralsOnlineDevelopmentTeam:main Jul 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants