NGMP: Use shared_ptr for WebSocket to manage its lifecycle - #58
Merged
Conversation
x64-dev
marked this pull request as ready for review
October 10, 2025 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CLIENT-CD. The issue was that: Use-after-free race condition: main thread deleted WebSocket object while networking worker thread held a dangling pointer to its internal mutex.
WebSocket*tostd::shared_ptr<WebSocket>inOnlineServices_Initto manage the WebSocket object's lifecycle using RAII.GetWebSocket()to returnstd::shared_ptr<WebSocket>.deletecalls withm_pWebSocket.reset()to release the WebSocket object when it's no longer needed, ensuring proper cleanup and preventing memory leaks.NetworkMeshto usestd::shared_ptr<WebSocket>when accessing the WebSocket instance.This fix was generated by Seer in Sentry, triggered by x64-dev. 👁️ Run ID: 1769217
Not quite right? Click here to continue debugging with Seer.