grdview: Fix the bug when -N is set but level is not specified - #9123
Open
seisman wants to merge 1 commit into
Open
grdview: Fix the bug when -N is set but level is not specified#9123seisman wants to merge 1 commit into
seisman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation (https://docs.generic-mapping-tools.org/dev/grdview#n), when
-Nis set but-Risn't, the default level should be the minimum value in the grid.However, the default level is set to 0 due to a bug. This can be verified by the following test:
When
-Ris not specified, GMT first determines the z-range based on the grid min/max values, then checks ifCtrl->N.levelis set and updates zmin toCtrl->N.levelif zmin<level, as shown below:gmt/src/grdview.c
Lines 990 to 996 in d52a1e5
However, when
-Nis set without any level,Ctrl->N.implicitistrueandCtrl->N.levelis not set untilgmt/src/grdview.c
Line 1320 in d52a1e5
so,
Ctrl->N.levelstill has the initial value (0.0), and then zmin is updated to0.0in this case.This PR fixes the issue.