Skip to content

Figure.choropleth: Improve the docstrings#4749

Merged
seisman merged 1 commit into
mainfrom
choropleth/docstring
Jul 23, 2026
Merged

Figure.choropleth: Improve the docstrings#4749
seisman merged 1 commit into
mainfrom
choropleth/docstring

Conversation

@seisman

@seisman seisman commented Jul 22, 2026

Copy link
Copy Markdown
Member

Two main changes:

  • "attribute field" makes more sense than "data column" for geopandas.GeoDataFrame
  • shapely.geometry with geometry but no attributes, then the column parameter doesn't work. So removing shapely.geometry from the desription.

Preview: https://pygmt-dev--4749.org.readthedocs.build/en/4749/api/generated/pygmt.Figure.choropleth.html

@seisman seisman added this to the 0.20.0 milestone Jul 22, 2026
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Jul 22, 2026
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. final review call This PR requires final review and approval from a second reviewer labels Jul 22, 2026
@seisman
seisman merged commit e578cc7 into main Jul 23, 2026
30 of 31 checks passed
@seisman
seisman deleted the choropleth/docstring branch July 23, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants