feat(import-design): validate DTCG output and type font-family tokens#6394
Merged
shipyard-local[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
Add validate_dtcg() — a dependency-free W3C Design Tokens conformance check (standard $type set, value/type shape, reserved $-keys, $extensions well-formedness) run over emitter output in tests. Promote confident font-family string tokens to $type "fontFamily" (comma stacks as the DTCG array form); park every other string losslessly under the document-root $extensions["dev.pulp.nonStandardTokens"] rather than emitting a non-standard $type "string". Emitter- and test-only: IRTokens, the parser, codegen, and the runtime theme are untouched, so existing importers and render flows are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014e8kbMn8Sf4mF8ozsy1Jot Skill-Update: skip skill=content reason="docs-only cli.md line tweak for --emit-w3c-tokens; no content-command change" Skill-Update: skip skill=kits reason="docs-only cli.md line tweak; no kits behavior change"
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the W3C DTCG token emitter (#6390). Adds conformance validation and accurate string typing — emitter + test only, so the importers and imported-design render/codegen flows are untouched.
What changed
validate_dtcg()— a dependency-free W3C Design Tokens conformance check (standard$typeset, value/type shape, reserved$-keys,$extensionswell-formedness), run over emitter output in tests and proven against known-bad documents.$type:"fontFamily"(comma stacks as the DTCG array form); the non-standard$type:"string"is gone.$extensions["dev.pulp.nonStandardTokens"].Non-breaking guarantee
Changes live only in
design_tokens_w3c.{hpp,cpp}+ its test + docs/skill.IRTokens, the parser, codegen, and the runtime theme are unchanged.Verification
token|import|codegen|theme|designmdregression tests pass — zero breakage.alpha/DESIGN.md): font families →fontFamily; 63 non-standard strings parked in$extensions, none dropped.🤖 Generated with Claude Code
🔎 Provenance
claudem5w1~/Code/fig-fixfd0e374f-d5dc-4e2a-bb33-6fa8b66124a0Resume
Jump to this tab
Relaunch (any agent)
Restore URL — https://claude.ai/code/session_014e8kbMn8Sf4mF8ozsy1Jot
stamped 2026-07-19 22:42 UTC