chore(test): register test_gate_common.py as a ctest#6412
Merged
Conversation
gate_common.py is the substrate every repo gate imports — trailer collection, range diffing, glob matching. Its test file runs nowhere. tools/scripts/test_*.py are not globbed into CI; coverage comes from explicit, hand-maintained lists, and this file is in none of them. test_gates.py does re-export some of this module's TestCase classes, so part of it has been running indirectly. That mechanism is an explicit import list, though, which makes the coverage silently partial: a class added to test_gate_common.py is invisible to CI until someone remembers to add it to test_gates.py's imports too. #6400 adds SquashBuriedBypassTrailerTests without that update, so its tests do not run. Registering the file directly runs whatever it contains, and holds regardless of the import list. Verified green in both orderings: 27 tests pass against gate_common.py as it stands on main, and 31 pass against #6400's version, so this is safe to land before or after that change. One add_test entry. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gate_common.py is the substrate every repo gate imports — trailer
collection, range diffing, glob matching. Its test file runs nowhere.
tools/scripts/test_*.py are not globbed into CI; coverage comes from
explicit, hand-maintained lists, and this file is in none of them.
test_gates.py does re-export some of this module's TestCase classes, so
part of it has been running indirectly. That mechanism is an explicit
import list, though, which makes the coverage silently partial: a class
added to test_gate_common.py is invisible to CI until someone remembers
to add it to test_gates.py's imports too. #6400 adds
SquashBuriedBypassTrailerTests without that update, so its tests do not
run. Registering the file directly runs whatever it contains, and holds
regardless of the import list.
Verified green in both orderings: 27 tests pass against gate_common.py
as it stands on main, and 31 pass against #6400's version, so this is
safe to land before or after that change.
One add_test entry. No behavior change.
🔎 Provenance
claudem3/Volumes/Workshop/Code/pulp-ctest-regc66f4a64-25ea-42e5-b184-d48611a066a2Resume
Jump to this tab
Relaunch (any agent)
Restore URL — https://claude.ai/code/session_01TVQHcnbg3t6TvXsdv6gXhS
stamped 2026-07-20 21:52 UTC