Skip to content

Feature/content labels#20

Merged
10dimensions merged 4 commits into
mainfrom
feature/content-labels
Oct 15, 2021
Merged

Feature/content labels#20
10dimensions merged 4 commits into
mainfrom
feature/content-labels

Conversation

@10dimensions

Copy link
Copy Markdown
Contributor
  • Added labels for web & media content

@10dimensions
10dimensions requested review from codynhat and gravenp June 28, 2021 17:11
@10dimensions 10dimensions self-assigned this Jun 28, 2021

@gravenp gravenp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in preview mode. Web Content URL added & properly links. Titles of media in the 3D Gallery are also shown as links which navigate the user back to the browser. Ideally, we'd remove these links and leave the titles of 3D content as read-only info @10dimensions.

@gravenp gravenp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@10dimensions Could you modify the font/size on the read-only media gallery title to match that of the URI? Sorry should have specified this, but we just want visual consistency across the two modes.

@10dimensions

Copy link
Copy Markdown
Contributor Author

Lost track of this :)
Will close the ticket this week

@gravenp

gravenp commented Oct 14, 2021

Copy link
Copy Markdown
Member

@10dimensions this is for #17

Here are screenshots of the two browser modes. Let's increase the size of the 3D Gallery content title font to be the same as the Web Content URI font. Also, if the URI or Content Title length exceeds the page width let's utilize text overflow with ellipses:

Screenshot_20211014-105051
Screenshot_20211014-105058

@gravenp gravenp linked an issue Oct 14, 2021 that may be closed by this pull request
@10dimensions

Copy link
Copy Markdown
Contributor Author

@gravenp Thanks for sharing the reference imgs.
I've managed to match the styles between url and content names.

It's just that the url is a hyperlink HTML element whereas the content name is a span text.
Do let me know if it's sufficient.

@gravenp

gravenp commented Oct 15, 2021

Copy link
Copy Markdown
Member

The new styling looks good. Go ahead and merge this PR when you're ready @10dimensions. Thanks!

@10dimensions
10dimensions merged commit 5f40244 into main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display the URL/media titles below the linked content in the browser

2 participants