fix mapstore extension variable#13775
Conversation
Summary of ChangesHello @allyoucanmap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important configuration issue within the GeoNode application. It specifically targets the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue with the MAPSTORE_EXTENSIONS_FOLDER_PATH by making it a relative path. This prevents potential bugs when joining this path with a base directory. I've added one suggestion to further improve consistency with other path-related settings in this file.
|
|
||
| # Extensions path to use in importing custom extensions into geonode | ||
| MAPSTORE_EXTENSIONS_FOLDER_PATH = "/mapstore/extensions/" | ||
| MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions/" |
There was a problem hiding this comment.
For consistency with other path component variables in this file, such as STATICFILES_LOCATION and MEDIAFILES_LOCATION, it's recommended to remove the trailing slash. This will make the path definitions more uniform across the settings file, improving maintainability and reducing potential confusion. os.path.join will handle this correctly.
| MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions/" | |
| MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions" |
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.