Skip to content

fix mapstore extension variable#13775

Merged
giohappy merged 1 commit intoGeoNode:masterfrom
allyoucanmap:issue_ext_variable
Nov 26, 2025
Merged

fix mapstore extension variable#13775
giohappy merged 1 commit intoGeoNode:masterfrom
allyoucanmap:issue_ext_variable

Conversation

@allyoucanmap
Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@allyoucanmap allyoucanmap added this to the 5.0.0 milestone Nov 26, 2025
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Nov 26, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @allyoucanmap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important configuration issue within the GeoNode application. It specifically targets the MAPSTORE_EXTENSIONS_FOLDER_PATH variable, which dictates where MapStore extensions are located. By removing an extraneous leading slash, the change ensures that the path is correctly interpreted, thereby facilitating the proper loading and functionality of these extensions within the system.

Highlights

  • Configuration Fix: The MAPSTORE_EXTENSIONS_FOLDER_PATH variable in geonode/settings.py has been corrected.
  • Path Correction: A leading forward slash was removed from the MAPSTORE_EXTENSIONS_FOLDER_PATH value to ensure proper path resolution for MapStore extensions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue with the MAPSTORE_EXTENSIONS_FOLDER_PATH by making it a relative path. This prevents potential bugs when joining this path with a base directory. I've added one suggestion to further improve consistency with other path-related settings in this file.

Comment thread geonode/settings.py

# Extensions path to use in importing custom extensions into geonode
MAPSTORE_EXTENSIONS_FOLDER_PATH = "/mapstore/extensions/"
MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions/"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other path component variables in this file, such as STATICFILES_LOCATION and MEDIAFILES_LOCATION, it's recommended to remove the trailing slash. This will make the path definitions more uniform across the settings file, improving maintainability and reducing potential confusion. os.path.join will handle this correctly.

Suggested change
MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions/"
MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions"

@giohappy giohappy merged commit 6385c7a into GeoNode:master Nov 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.0.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants