Skip to content

fix mapstore extension variable #13775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giohappy merged 1 commit into from
Nov 26, 2025
Merged

fix mapstore extension variable #13775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion geonode/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1551,7 +1551,7 @@ def get_geonode_catalogue_service():
MAPSTORE_PLUGINS_CONFIG_PATCH_RULES = []

# Extensions path to use in importing custom extensions into geonode
MAPSTORE_EXTENSIONS_FOLDER_PATH = "/mapstore/extensions/"
MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions/"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other path component variables in this file, such as STATICFILES_LOCATION and MEDIAFILES_LOCATION, it's recommended to remove the trailing slash. This will make the path definitions more uniform across the settings file, improving maintainability and reducing potential confusion. os.path.join will handle this correctly.

Suggested change
MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions/"
MAPSTORE_EXTENSIONS_FOLDER_PATH = "mapstore/extensions"


# Supported Dataset file types for uploading Datasets. This setting is being from from the client

Expand Down
Loading