[Fixes #14219] Implement permissons diffing#14218
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a structured mechanism for diffing and patching resource permissions by adding a diff method to PermSpecCompact and implementing the PermSpecCompactDiff class. The patch_perms utility and the resource permissions API view were updated to utilize this new logic. Review feedback identified a high-severity issue where missing buckets in a permission spec are incorrectly treated as removals, potentially breaking partial updates. Additionally, an optimization was suggested for the apply method to improve the efficiency of adding new permission entries.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14218 +/- ##
===========================================
+ Coverage 43.23% 74.76% +31.53%
===========================================
Files 960 967 +7
Lines 58824 59351 +527
Branches 8018 8069 +51
===========================================
+ Hits 25432 44375 +18943
+ Misses 32113 13169 -18944
- Partials 1279 1807 +528 🚀 New features to boost your workflow:
|
No description provided.