Skip to content

[Fixes #14217] PUT must replace and not merge permissions#14221

Merged
giohappy merged 3 commits into
masterfrom
ISSUE_14217
May 14, 2026
Merged

[Fixes #14217] PUT must replace and not merge permissions#14221
giohappy merged 3 commits into
masterfrom
ISSUE_14217

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

Fixes #14217

Note: This PR depends on #14218 and should be merged after that PR.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 13, 2026
@sijandh35 sijandh35 requested a review from giohappy May 13, 2026 06:34
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the resource service permissions API to support merging permissions via PATCH and replacing them via PUT, including new test cases for these operations. The implementation refactors the view logic to use a PermSpecCompact utility for handling permission specifications. However, the review highlights critical issues in the updated logic, specifically a type mismatch where an object is passed instead of a dictionary, a failure to support permission removals in the underlying patch_perms function, and an incorrect argument order in the function call.

Comment thread geonode/base/api/views.py
@sijandh35 sijandh35 self-assigned this May 13, 2026
@sijandh35 sijandh35 marked this pull request as ready for review May 14, 2026 09:26
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 96.33028% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.80%. Comparing base (787ed72) to head (bd7d045).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14221      +/-   ##
==========================================
+ Coverage   74.76%   74.80%   +0.03%     
==========================================
  Files         967      967              
  Lines       59351    59442      +91     
  Branches     8069     8075       +6     
==========================================
+ Hits        44375    44463      +88     
- Misses      13169    13171       +2     
- Partials     1807     1808       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sijandh35 sijandh35 assigned giohappy and sijandh35 and unassigned sijandh35 May 14, 2026
@giohappy giohappy merged commit ef6a446 into master May 14, 2026
26 checks passed
@giohappy giohappy deleted the ISSUE_14217 branch May 14, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PUT must replace and not merge permissions

2 participants