[Fixes #14217] PUT must replace and not merge permissions#14221
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the resource service permissions API to support merging permissions via PATCH and replacing them via PUT, including new test cases for these operations. The implementation refactors the view logic to use a PermSpecCompact utility for handling permission specifications. However, the review highlights critical issues in the updated logic, specifically a type mismatch where an object is passed instead of a dictionary, a failure to support permission removals in the underlying patch_perms function, and an incorrect argument order in the function call.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #14221 +/- ##
==========================================
+ Coverage 74.76% 74.80% +0.03%
==========================================
Files 967 967
Lines 59351 59442 +91
Branches 8069 8075 +6
==========================================
+ Hits 44375 44463 +88
- Misses 13169 13171 +2
- Partials 1807 1808 +1 🚀 New features to boost your workflow:
|
Fixes #14217
Note: This PR depends on #14218 and should be merged after that PR.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.