Skip to content

[Fixes #14394] remove support of GoogleCloudStorage#14400

Open
mattiagiupponi wants to merge 1 commit into
masterfrom
ISSUE_14394
Open

[Fixes #14394] remove support of GoogleCloudStorage#14400
mattiagiupponi wants to merge 1 commit into
masterfrom
ISSUE_14394

Conversation

@mattiagiupponi

Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from giohappy July 2, 2026 08:40
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jul 2, 2026
@mattiagiupponi mattiagiupponi linked an issue Jul 2, 2026 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes Google Cloud Storage support from the codebase. Specifically, it deletes the Google Storage Manager implementation, removes its corresponding unit tests in geonode/storage/tests.py, and removes the google-cloud-storage dependency from pyproject.toml. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cesarbenjamindotnet

Copy link
Copy Markdown

I believe there hasn't been much progress because this area is not fully implemented yet. Many parts of the system still depend on direct disk access, and currently there is no way to use Google Cloud Storage seamlessly. More importantly, supporting GCS should really be viewed as supporting cloud storage in general, regardless of the underlying provider.

At the moment, many components—especially the importer—still rely on physical file system access. This prevents the application from working properly with cloud storage backends.

Django already has the django-storages package, which I believe should be the foundation for provider-agnostic cloud storage support. Rather than removing cloud storage support, the storage layer should be refactored so that it no longer depends on physical disk paths.

I believe the proposal to remove cloud storage support is fundamentally misguided. In reality, cloud storage support is still incomplete, and removing it would be a regression rather than an improvement. In my opinion, it is a very poor proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop the support for Google storage

3 participants