Skip to content

[Fixes #14406] Introducing a new setting for the URL validation#14407

Merged
Gpetrak merged 2 commits into
masterfrom
ISSUE_14406
Jul 9, 2026
Merged

[Fixes #14406] Introducing a new setting for the URL validation#14407
Gpetrak merged 2 commits into
masterfrom
ISSUE_14406

Conversation

@Gpetrak

@Gpetrak Gpetrak commented Jul 3, 2026

Copy link
Copy Markdown
Member

This PR was created according to this issue: #14406

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@Gpetrak Gpetrak added this to the 5.2.0 milestone Jul 3, 2026
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jul 3, 2026
@Gpetrak Gpetrak linked an issue Jul 3, 2026 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the SAFE_URL_TRUSTED_HOSTS setting to allow trusted hosts to bypass URL safety validation, even when resolving to private IPs. The review feedback highlights several critical improvements: normalizing the port check in geonode/utils.py to handle implicit default ports (80/443) and hostnames without ports; making the environment variable parsing in geonode/settings.py more robust by falling back to comma-separated parsing on failure; and adding comprehensive test cases to cover these edge cases.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread geonode/utils.py Outdated
Comment thread geonode/settings.py
Comment thread geonode/tests/test_utils.py
@Gpetrak Gpetrak marked this pull request as ready for review July 3, 2026 07:48
Comment thread geonode/utils.py Outdated
Comment thread .env.sample
@Gpetrak Gpetrak requested a review from mattiagiupponi July 6, 2026 07:18
@Gpetrak Gpetrak merged commit c3f53cc into master Jul 9, 2026
15 checks passed
@Gpetrak Gpetrak deleted the ISSUE_14406 branch July 9, 2026 08:19
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

The backport to 5.0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0.x 5.0.x
# Navigate to the new working tree
cd .worktrees/backport-5.0.x
# Create a new branch
git switch --create backport-14407-to-5.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3f53cc63e2b8a51c0a93f51976cbb190c202820
# Push it to GitHub
git push --set-upstream origin backport-14407-to-5.0.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0.x

Then, create a pull request where the base branch is 5.0.x and the compare/head branch is backport-14407-to-5.0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.0.x backport 5.1.x cla-signed CLA Bot: community license agreement signed enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a new setting for the URL validation

3 participants