Skip to content

[Fixes #4635] Encoding issues when uploading layers using a shapefile#5269

Merged
afabiani merged 1 commit into
masterfrom
ISSUE_4635
Nov 14, 2019
Merged

[Fixes #4635] Encoding issues when uploading layers using a shapefile#5269
afabiani merged 1 commit into
masterfrom
ISSUE_4635

Conversation

@afabiani

Copy link
Copy Markdown
Member

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Nov 14, 2019
@codecov

codecov Bot commented Nov 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5269 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5269   +/-   ##
=======================================
  Coverage   56.11%   56.11%           
=======================================
  Files         173      173           
  Lines       19139    19139           
  Branches     2980     2980           
=======================================
  Hits        10740    10740           
  Misses       7391     7391           
  Partials     1008     1008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encoding issues when uploading layers using a shapefile

1 participant