fix: v5 follow-ups: Version() prefix, migration guide, release major guard - #134
Merged
Conversation
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 09:45 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 09:45 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 09:45 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 09:45 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 09:45 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 09:45 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:02 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:02 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:02 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:02 — with
GitHub Actions
Inactive
mogita
had a problem deploying
to
feeds-enabled-shard
July 27, 2026 10:02 — with
GitHub Actions
Failure
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:02 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:04 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:15 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:15 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:15 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:15 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:15 — with
GitHub Actions
Inactive
mogita
temporarily deployed
to
feeds-enabled-shard
July 27, 2026 10:15 — with
GitHub Actions
Inactive
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to the v5 major, split out of #133 (which is now empty: #130 landed the module path fix and #131 shipped it as v5.1.0).
1.
MIGRATION_v4_to_v5.mdv4 -> v5 had no upgrade doc. The actual breaking surface is small, and it was verified by compiling a probe against
v4.2.2andv5.1.0rather than read off the commit message:AppResponseFields.ModerationAudioFileEnabledremoved.ModerationDashboardPreferences.AnalyzeMaxImageSizeBytes,.AnalyzeMaxKeyframeSizeBytes,.WebhookHeaderClientRequestIDKeyremoved.CheckResponseis no longer comparable with==: it gainedTriggeredRules []TriggeredRuleResponse. This propagates toStreamResponse[CheckResponse].Everything else in v4 -> v5 is additive. Note the v5.0.0 release notes claimed the Video
CallResponsewas affected by the moderationCallResponserename; it is not, and the guide says so. README now links both major-upgrade guides.2. Release guard in
initiate_release.ymlThe v5.0.0 hole exists because the release workflow happily cut a
v5tag from a tree whosego.modsaidgithub.com/GetStream/getstream-go/v4. Go rejects that combination, so the tag was dead on arrival and@latestsilently stayed on v4.2.2 until v5.1.0.The new step compares the requested major against the
/vNsuffix ingo.modand fails the workflow before the changelog is generated. Logic checked against:v5.1.0+/v4(the historical bug, fails),v6.0.0+/v5(fails),v5.2.0+/v5(passes),v2.0.0+ no suffix (fails),v1.4.0andv0.3.0+ no suffix (pass),v10.0.0+/v10(passes),v10.0.0+/v1(fails).3.
Version()returnedvv5.1.0versionNamealready carries the leadingv(the release workflow writes the tag verbatim), so"v" + versionNamedoubled it. Long-standing:v4.2.2had it too.versionHeader()and theX-Stream-Clientheader were never affected.4. The v5.0.0 tag and release are deleted
Nothing was ever published for that version:
proxy.golang.org404s it andsum.golang.orghas no entry, so there is no checksum to invalidate and nobody can be pinned to it. Re-tagging it atmainwas the alternative and was rejected: it would produce a v5.0.0 containing more code than v5.1.0 while sorting below it.The two CHANGELOG compare links that pointed at the deleted tag are repointed, and the 5.0.0 section now says where its contents shipped.
Verification
make test-unitpasses,go build ./...andgo vet ./...clean,make lintreformats nothing, workflow YAML parses.