Skip to content

chore: add structured logging with secret redaction#72

Merged
mogita merged 2 commits into
masterfrom
feat/cha-2957-logging
Jul 22, 2026
Merged

chore: add structured logging with secret redaction#72
mogita merged 2 commits into
masterfrom
feat/cha-2957-logging

Conversation

@mogita

@mogita mogita commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Ticket

https://linear.app/stream/issue/CHA-2957/logging

Summary

Adds structured logging via the existing logger: kwarg (stdlib Logger): client.initialized, http.request.sent, http.response.received, http.request.failed. Mandatory redaction of secret query params and known-secret body keys. Opt-in log_bodies with a one-shot WARN.

Behavior change

The prior $stdout fallback for the pool-config line is removed; with no logger injected the client produces no output.

Tests

make test green (294); spec/logging_spec.rb covers events, redaction, the no-logger case, and the transport-message scrub.

@mogita mogita changed the title feat: add structured logging with secret redaction chore: add structured logging with secret redaction Jul 22, 2026
@mogita

mogita commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

Titled chore: (not feat:) intentionally: this repo's Release workflow derives the version bump from the PR-title type and skips releasing when the type is not feat/fix, so merging this will not auto-publish. The change is a feature; when you want to publish, run the Release workflow manually (workflow_dispatch, version bump = minor).

@mogita
mogita merged commit 3c09c3c into master Jul 22, 2026
10 of 11 checks passed
@mogita
mogita deleted the feat/cha-2957-logging branch July 22, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant