[INF-1722] Keep single deletes on primary key - #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Summary
Remove redundant equal lower and upper composite-row bounds from single-row primary-key DELETEs. In the live c3 target, those bounds made PostgreSQL choose the 39 GB
channels_app_pk_created_at_cid_retention_idxinstead of the uniquechannels_pkey, producing a roughly 4.5 minute delete outlier.Exact scalar equalities remain in catalog primary-key order, so row identity and delete semantics are unchanged while the planner can select the unique primary key.
Validation
go test ./...go vet ./...go test -race ./internal/cdcchannels_pkeyRollout
Checklist