Feature/message list view - #15
Merged
Merged
Conversation
| messageListItemList = newEntities; | ||
| result.dispatchUpdatesTo(this); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
isn't it better to first dispatchUpdates and after that swap the variable?
Contributor
Author
There was a problem hiding this comment.
Yep, that is the normal, but not important.
| </data> | ||
|
|
||
| <androidx.constraintlayout.widget.ConstraintLayout | ||
| <RelativeLayout |
Member
There was a problem hiding this comment.
it's recommended to always use constraint layout these days right?
| private ViewChannelHeaderBinding initBinding(Context context) { | ||
| LayoutInflater inflater = LayoutInflater.from(context); | ||
| binding = ToolbarChannelHeaderBinding.inflate(inflater, this, true); | ||
| binding = ViewChannelHeaderBinding.inflate(inflater, this, true); |
JcMinarro
pushed a commit
that referenced
this pull request
Oct 20, 2020
…vent_handling Fix NotificationAddedToChannelEvent event handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request