Feature/reactioninput#23
Closed
tbarbugli wants to merge 50 commits into
Closed
Conversation
resolved conflicts # Conflicts: # library/src/main/java/com/getstream/sdk/chat/adapter/ChannelListItemAdapter.java
resolved conflicts # Conflicts: # library/src/main/java/com/getstream/sdk/chat/adapter/MessageListItemViewHolder.java
Member
Author
|
@adrian09h closing this; if you can apply only the relevant changes from a fresh branch (out of latest master). Watch out for my other PR, we might need that one merged first |
JcMinarro
added a commit
that referenced
this pull request
Oct 20, 2020
Handle error when a channel is created with a bad CID
VelikovPetar
added a commit
that referenced
this pull request
May 29, 2026
Brings PR #6426 (Predefined Filters) into the branch alongside the existing Grouped Channels work. Both implementations coexist as sibling variants of `QueryChannelsIdentifier` (Standard | Predefined | Grouped); registries, repositories, state, and the Compose ChannelListViewModel/Factory absorb both surfaces additively. Key resolution decisions: - `QueryChannelsSpec.cids` stays as a body `var` (pre-v6 baseline) to preserve binary compatibility with the data-class-generated members. `setCids` mutates the var in place. - `QueryChannelsMutableState` keeps the simpler `(identifier, scope, ...)` constructor; initial filter/sort and the spec shape are derived inside the state from the identifier, so `StateRegistry` is just a registry-cache lookup. - `QueryChannelsLogic.fetchChannelsFromCache` adopts v6's identifier-keyed signature returning `CachedQueryChannels`; the Grouped offline path (`loadOfflineGroupedChannels`) goes through the same signature and unwraps `.channels`. - `@JvmOverloads` dropped on the Compose Factory's Predefined and Grouped constructors because their synthesized `(ChatClient, String)` overloads clash — see task #23 for the proper fix. Verification: builds clean across client/state/offline/compose/ui-components, apiCheck passes, all unit tests on touched modules pass, detekt clean except for three intentional TODO-marker comments left for follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.