Migrate block/unblock user endpoints to generated models#6544
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
08a4ba4 to
10f78c0
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
WalkthroughBlock and unblock user request/response DTOs are renamed from singular (BlockUserRequest/Response, UnblockUserRequest/Response) to plural bulk types (BlockUsersRequest/Response, UnblockUsersRequest/Response), moved to ChangesBlock/Unblock user model migration
Estimated code review effort: 2 (Simple) | ~12 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
10f78c0 to
cdc0754
Compare
|
|
🚀 Available in v7.6.0 |



Goal
Migrate the
/users/blockand/users/unblockendpoints to generated request/response models. Part of the incremental OpenAPI model migration: generated models keep their generated package (io.getstream.chat.android.network.models) asinternalclasses inside the client module, one endpoint at a time.Part of AND-1291
Implementation
BlockUsersRequest,BlockUsersResponse,UnblockUsersRequest,UnblockUsersResponseand delete the four hand-written DTOs.UserApi,MoshiChatApi, and thetoDomain()mapper at the generated types (real names, no import aliases), updating field access to the generated camelCase names.queryBlockedUsersis left untouched (independent). Also fixes a pre-existing copy-paste where the unblock test argument used the block response type.Testing
spotlessApply,apiDump(no API drift),lint,detekt, andtestDebugUnitTestall pass.UserBlock), then unblock succeeds.Summary by CodeRabbit
New Features
Tests