ci: install AWS CLI on self-hosted runner for S3 upload#3726
Merged
Conversation
The S3 upload restored in #3725 fails on the self-hosted `public` runner because the AWS CLI is not installed there. Add a step that installs AWS CLI v2 when missing (no-op if already present), to a user-writable dir without sudo, and exposes it via GITHUB_PATH so the upload step can run.
Contributor
|
🎉 This PR is included in version 9.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Follow-up to #3725 (merged), which restored the SampleApp Android APK upload to S3 that powers
https://getstream.io/downloads/rn-sample-app.apk. That upload fails on the self-hostedpublicrunner because the AWS CLI is not installed there (the original S3 job ran on GitHub-hostedubuntu-latest, whereawsis preinstalled). This PR makes the job install the AWS CLI when it is missing so the upload can succeed.🛠 Implementation details
Adds an
Ensure AWS CLI is availablestep to thebuild_and_deploy_android_firebasejob insample-distribution.yml, before the AWS credentials/upload steps:awsis already onPATH(so it costs nothing if the runner image gains the CLI later).x86_64/aarch64).$HOME/.local/...) with nosudo, then appends the bin dir to$GITHUB_PATHso the subsequentUpload APK to S3step picks it up.developonly, matching the rest of the S3 flow.🎨 UI Changes
N/A — CI/workflow-only change, no UI impact.
🧪 Testing
CI-only change; verified by the
developpipeline rather than the example apps:develop, thebuild_and_deploy_android_firebasejob runs the new install step and logs the resolvedaws --version.Upload APK to S3step now succeeds in the Actions logs.https://getstream.io/downloads/rn-sample-app.apkserves the latest build.☑️ Checklist
developbranch