Skip to content

fix(Channel): respect false shouldGenerateVideoThumbnail prop#3184

Merged
MartinCupela merged 1 commit into
masterfrom
fix/Channel/respect-shouldGenerateVideoThumbnail
May 11, 2026
Merged

fix(Channel): respect false shouldGenerateVideoThumbnail prop#3184
MartinCupela merged 1 commit into
masterfrom
fix/Channel/respect-shouldGenerateVideoThumbnail

Conversation

@MartinCupela
Copy link
Copy Markdown
Contributor

🎯 Goal

Fixes #3182

@github-actions
Copy link
Copy Markdown

Size Change: -1 B (0%)

Total Size: 680 kB

πŸ“¦ View Changed
Filename Size Change
dist/cjs/emojis.js 3.01 kB +1 B (+0.03%)
dist/cjs/useNotificationApi.js 45.4 kB +1 B (0%)
dist/es/emojis.mjs 2.52 kB -1 B (-0.04%)
dist/es/index.mjs 269 kB -1 B (0%)
dist/es/useNotificationApi.mjs 45.2 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
dist/cjs/audioProcessing.js 1.32 kB
dist/cjs/index.js 270 kB
dist/cjs/mp3-encoder.js 1.27 kB
dist/css/emoji-picker.css 178 B
dist/css/emoji-replacement.css 456 B
dist/css/index.css 39.7 kB
dist/es/audioProcessing.mjs 1.31 kB
dist/es/mp3-encoder.mjs 756 B

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 83.68%. Comparing base (1028763) to head (a4eb7bc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3184      +/-   ##
==========================================
+ Coverage   83.65%   83.68%   +0.03%     
==========================================
  Files         435      435              
  Lines       13028    13028              
  Branches     4202     4202              
==========================================
+ Hits        10899    10903       +4     
+ Misses       2129     2125       -4     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinCupela MartinCupela merged commit 340af2b into master May 11, 2026
9 checks passed
@MartinCupela MartinCupela deleted the fix/Channel/respect-shouldGenerateVideoThumbnail branch May 11, 2026 10:58
github-actions Bot pushed a commit that referenced this pull request May 11, 2026
## [14.2.0](v14.1.0...v14.2.0) (2026-05-11)

### Bug Fixes

* allow content overflow in generic Button ([#3167](#3167)) ([6735fa1](6735fa1))
* **Avatar:** fall back to initials when imageUrl is an empty string ([#3168](#3168)) ([541eef8](541eef8))
* **Channel:** respect false shouldGenerateVideoThumbnail prop ([#3184](#3184)) ([340af2b](340af2b))
* decouple modern-normalize from the SDK ([#3180](#3180)) ([bcaf1f6](bcaf1f6)), closes [#3134](#3134)
* extended reactions button adjustments ([#3172](#3172)) ([5259c17](5259c17))
* prevent messages being squashed in narrow message lists ([#3153](#3153)) ([a1cc63f](a1cc63f))
* prevent overriding active channel UI on ChannelList pagination error ([#3164](#3164)) ([0c0d65c](0c0d65c))
* remove visual glitches in ModalGallery, placeholder color, borders ([#3178](#3178)) ([32dcace](32dcace))

### Features

* **a11y:** announce message bubble text with context ([#3177](#3177)) ([16f7294](16f7294))
* **a11y:** make ChannelListItemActionButtons accessible with keyboard ([#3176](#3176)) ([8a6b90c](8a6b90c))
* add authorLabel prop to QuotedMessagePreviewUIProps ([#3162](#3162)) ([88ef71e](88ef71e))
* add matchReferenceWidth to DropdownProps ([#3166](#3166)) ([cef7fa5](cef7fa5))
* add pin icon to the ChannelListItemUI ([#3163](#3163)) ([f37f0a9](f37f0a9))
* add snackbar notification upon channels query pagination failure ([#3179](#3179)) ([1028763](1028763))
* clear command mode in message composer using keyboard ([#3175](#3175)) ([6257e17](6257e17))
* introduce selective command enablement based on message editing or quoting in message composer ([#3171](#3171)) ([8fa096a](8fa096a))
@stream-ci-bot
Copy link
Copy Markdown

πŸŽ‰ This PR is included in version 14.2.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Channel prop shouldGenerateVideoThumbnail={false}has no effect due to||vs??` operator

3 participants