Skip to content

Add support for custom HTTP headers in ChatClientConfig.urlSessionConfiguration #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nuno-vieira merged 7 commits into from
Oct 3, 2023
Merged

Add support for custom HTTP headers in ChatClientConfig.urlSessionConfiguration #2818

nuno-vieira merged 7 commits into from
Oct 3, 2023

Conversation

@nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Oct 2, 2023 •
edited
Loading

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/568

🎯 Goal

Adds support for providing custom HTTP headers for every response.

🧪 Manual Testing Notes

  1. Open Proxyman
  2. Observe Requests in the DemoApp
  3. It should include a new header "Custom": "Example"

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK ✅ Feature An issue or PR related to a feature labels Oct 2, 2023
@nuno-vieira nuno-vieira requested a review from a team as a code owner October 2, 2023 18:11
@nuno-vieira nuno-vieira changed the title Add support for custom HTTP headers in ChatClientConfig Add support for custom HTTP headers in ChatClientConfig.urlSessionConfiguration Oct 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

89.7% 89.7% Coverage
0.0% 0.0% Duplication

martinmitrevski
martinmitrevski approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@nuno-vieira nuno-vieira merged commit f956ddf into develop Oct 3, 2023
@nuno-vieira nuno-vieira deleted the add/allow-mutating-http-headers branch October 3, 2023 10:00
@polqf polqf mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

No one assigned

Labels

✅ Feature An issue or PR related to a feature 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nuno-vieira @martinmitrevski