Link channel when it becomes visible #2819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
nuno-vieira
reviewed
Oct 3, 2023
Sources/StreamChat/Controllers/ChannelListController/ChannelListController.swift
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix the issue which happens when showing a hidden channel outside a channel list.
📝 Summary
It seems we are not linking the channel in those scenarios, now we listen to the event and do that.
🛠 Implementation
Simple addition to the
eventsControllerdelegate inChatChannelListController.🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
It's a bit tricky to test this, since it's usually on customer side, where the channel id is stored on a certain screen. You can test it by calling show/hide channel on a hardcoded channel id.
☑️ Contributor Checklist
🎁 Meme