Skip to content

Always use reloadChannels() in Channel List #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nuno-vieira merged 5 commits into from
Nov 2, 2023
Merged

Always use reloadChannels() in Channel List #2858

nuno-vieira merged 5 commits into from
Nov 2, 2023

Conversation

@nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Oct 30, 2023 •
edited
Loading

🔗 Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/617

🎯 Goal

Add consistency to how the Channel List data is updated and improve its stability,

🎨 Showcase

N/A

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira requested a review from a team as a code owner October 30, 2023 16:28
@nuno-vieira nuno-vieira merged commit 266bcb9 into develop Nov 2, 2023
@nuno-vieira nuno-vieira deleted the fix/always-use-reloadChannels-in-channe-list branch November 2, 2023 15:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

90.2% 90.2% Coverage
0.0% 0.0% Duplication

@testableapple testableapple mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nuno-vieira @martinmitrevski