v5: Add MediaBadgeDurationFormatter + Attachment Picker Icons#3975
v5: Add MediaBadgeDurationFormatter + Attachment Picker Icons#3975nuno-vieira merged 2 commits intov5from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Generated by 🚫 Danger |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
StreamChat.xcodeproj/project.pbxproj (1)
1096-1102:⚠️ Potential issue | 🔴 CriticalAdd MediaBadgeDurationFormatter.swift to the StreamChatCommonUI target.
The test file is correctly added at line 1101, but the source file
MediaBadgeDurationFormatter.swiftis missing from the StreamChatCommonUI target's references in project.pbxproj. The file exists atSources/StreamChatCommonUI/Appearance+Formatters/MediaBadgeDurationFormatter.swiftbut is not listed in the target's configuration. It must be added to the Exceptions for "Sources" folder in "StreamChatCommonUI" target alongside other similar formatter files likeAudioPlaybackRateFormatter.swiftandMarkdownFormatter.swift.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@StreamChat.xcodeproj/project.pbxproj` around lines 1096 - 1102, The StreamChatCommonUI target in project.pbxproj is missing an entry for MediaBadgeDurationFormatter.swift; open the project.pbxproj, find the StreamChatCommonUI target's "Sources" file list / Exceptions block (the same area that contains AudioPlaybackRateFormatter.swift and MarkdownFormatter.swift) and add a reference for Sources/StreamChatCommonUI/Appearance+Formatters/MediaBadgeDurationFormatter.swift so the file is included in the StreamChatCommonUI target build phases; ensure the file reference identifier and filename string match the project's existing pattern for other formatter sources.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@StreamChat.xcodeproj/project.pbxproj`:
- Around line 1096-1102: The StreamChatCommonUI target in project.pbxproj is
missing an entry for MediaBadgeDurationFormatter.swift; open the
project.pbxproj, find the StreamChatCommonUI target's "Sources" file list /
Exceptions block (the same area that contains AudioPlaybackRateFormatter.swift
and MarkdownFormatter.swift) and add a reference for
Sources/StreamChatCommonUI/Appearance+Formatters/MediaBadgeDurationFormatter.swift
so the file is included in the StreamChatCommonUI target build phases; ensure
the file reference identifier and filename string match the project's existing
pattern for other formatter sources.
StreamChat XCSize
|
Public Interface+ open class DefaultMediaBadgeDurationFormatter: MediaBadgeDurationFormatter
+
+ public init()
+
+
+ open func longFormat(_ duration: TimeInterval)-> String
+ open func shortFormat(_ duration: TimeInterval)-> String
+ public protocol MediaBadgeDurationFormatter
- open class DefaultVideoDurationShortFormatter: VideoDurationShortFormatter
-
- public var dateComponentsFormatter: DateComponentsFormatter
-
-
- public init()
-
-
- open func format(_ duration: TimeInterval)-> String?
- public protocol VideoDurationShortFormatter
|
SDK Size
|
StreamChatCommonUI XCSize
|
|
3 participants
🔗 Issue Links
LLC PR for: GetStream/stream-chat-swiftui#1215
📝 Summary
MediaBadgeDurationFormatterand changes formatting logic according to Figma updated designs🧪 Manual Testing Notes
N/A
☑️ Contributor Checklist
docs-contentrepoSummary by CodeRabbit
New Features
UI/Icons