Skip to content

Conversation

@renefloor
Copy link
Collaborator

Submit a pull request

Closes FLU-251

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

The id is used to identify reactions for updates or additions. The ID was not specific enough and might lead to updating wrong comment. This makes it more specific.

Same as: https://github.com/GetStream/stream-feeds-swift/blob/develop/Sources/StreamFeeds/Models/FeedsReactionData.swift#L19-L25

@renefloor renefloor requested a review from a team as a code owner October 28, 2025 12:28
@renefloor renefloor changed the title Improve on local FeedsReactionData id fix(llc): Improve on local FeedsReactionData id Oct 28, 2025
@renefloor renefloor enabled auto-merge (squash) October 28, 2025 12:31
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.88%. Comparing base (6926cb7) to head (301a1a9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ream_feeds/lib/src/models/feeds_reaction_data.dart 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   20.90%   20.88%   -0.02%     
==========================================
  Files         120      120              
  Lines        3287     3289       +2     
==========================================
  Hits          687      687              
- Misses       2600     2602       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renefloor renefloor merged commit d08e4e9 into main Oct 28, 2025
7 of 10 checks passed
@renefloor renefloor deleted the fix/feeds-reaction-data-id branch October 28, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants