Skip to content

fix(llc): Improve on local FeedsReactionData id #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

fix(llc): Improve on local FeedsReactionData id #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f629c8
Improve on local FeedsReactionData id
renefloor Oct 28, 2025
301a1a9
update changelog
renefloor Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/stream_feeds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## unreleased
- Update follower and following counts on the feed state when receiving follow websocket events.
- Fix FeedsReactionData id for updating reactions in the feed state.

## 0.3.1
- Update API client with renaming `addReaction` to `addActivityReaction` and `deleteReaction` to `deleteActivityReaction`.
Expand Down
7 changes: 6 additions & 1 deletion packages/stream_feeds/lib/src/models/feeds_reaction_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class FeedsReactionData with _$FeedsReactionData {
/// Creates a new [FeedsReactionData] instance.
const FeedsReactionData({
required this.activityId,
this.commentId,
required this.createdAt,
required this.type,
required this.updatedAt,
Expand All @@ -25,6 +26,8 @@ class FeedsReactionData with _$FeedsReactionData {
@override
final String activityId;

final String? commentId;

/// The date and time when the reaction was created.
@override
final DateTime createdAt;
Expand All @@ -46,7 +49,8 @@ class FeedsReactionData with _$FeedsReactionData {
final Map<String, Object?>? custom;

/// Unique identifier for the reaction, generated from the activity ID and user ID.
String get id => '$activityId${user.id}';
String get id =>
'${user.id}-$type${commentId == null ? '' : '-$commentId'}-$activityId';
}

/// Extension function to convert a [FeedsReactionResponse] to a [FeedsReactionData] model.
Expand All @@ -55,6 +59,7 @@ extension FeedsReactionResponseMapper on FeedsReactionResponse {
FeedsReactionData toModel() {
return FeedsReactionData(
activityId: activityId,
commentId: commentId,
createdAt: createdAt,
type: type,
updatedAt: updatedAt,
Expand Down
Loading