Skip to content

Fix iOS playback volume drop after re-muting#89

Merged
ipavlidakis merged 1 commit into
iliaspavlidakis/merge-webrtc-m145from
iliaspavlidakis/m145/fix-audio-output-gain-issue
May 18, 2026
Merged

Fix iOS playback volume drop after re-muting#89
ipavlidakis merged 1 commit into
iliaspavlidakis/merge-webrtc-m145from
iliaspavlidakis/m145/fix-audio-output-gain-issue

Conversation

@ipavlidakis
Copy link
Copy Markdown
Contributor

Summary

  • Keep the iOS audio input graph alive when all send streams are muted.
  • Prevent muting from stopping ADM recording, which recreated the AVAudioEngine as output-only and reduced playback loudness.
  • Add an AudioState regression test covering mute changes without recording teardown.

Test plan

  • git diff --check
  • bundle exec fastlane ios build verbose:true zip_product_skip:true root:/Users/ipavlidakis/workspace/webrtc/src build_root:/Users/ipavlidakis/workspace/webrtc/src configure_google_client_skip:true skip_licenses:true maccatalyst_support:false sign_product_skip:true verify_signatures_skip:true

@ipavlidakis ipavlidakis self-assigned this May 18, 2026
@ipavlidakis ipavlidakis added the bug Something isn't working label May 18, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d8936d25-0ae8-46ad-89dc-3fd266260506

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch iliaspavlidakis/m145/fix-audio-output-gain-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ipavlidakis ipavlidakis merged commit ade303a into iliaspavlidakis/merge-webrtc-m145 May 18, 2026
1 check passed
@ipavlidakis ipavlidakis deleted the iliaspavlidakis/m145/fix-audio-output-gain-issue branch May 18, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants