Skip to content

data: add 18 display/PC brands + unlock 122 monitors & 16 laptops#106

Merged
Seungpyo1007 merged 4 commits into
mainfrom
data/import-staging
Jul 8, 2026
Merged

data: add 18 display/PC brands + unlock 122 monitors & 16 laptops#106
Seungpyo1007 merged 4 commits into
mainfrom
data/import-staging

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

What & why

Adds 18 established display/PC brands that were missing from the catalog, which unlocks devices previously skipped on import: +122 monitors and +16 laptops.

  • Brands (18): ViewSonic, AOpen, AOC, Sceptre, Planar, Alienware (Dell sub-brand), Chuwi, Thermaltake, Colorful, Thomson, Elo, Kensington, Targus, KOORUI, Pixio, INNOCN, InnoView, Lilliput — categorized pc-oem, with country/founded-year/description.
  • Monitors (+122): AOpen (70), ViewSonic, Sceptre, KOORUI, AOC, Lilliput, Planar, InnoView, Alienware, Pixio, INNOCN, Kensington (Amazon dataset, CC BY 4.0).
  • Laptops (+16): Alienware (7, with cpu/gpu FK), Thomson, Chuwi, Colorful (abhinavflac dataset).

All verified: false. Only truly-established brands were added — one-off obscure Amazon-seller brands (Domyfan, Fiodio, cocopar, …) were deliberately left out to keep the brand catalog clean.

Commits (each Refs #1): brand records, monitor import, laptop import, surgical dump refresh.

Closes #1

Checklist

  • python -m app.validate — ✅ passed (brands valid: ISO country, pc-oem category, path)
  • python TechEngine/integrity_check.py data --strict — ✅ no hard anomalies
  • git diff --check — ✅ clean
  • Correct paths, kebab-case unique slugs, source_urls present

Add 18 established display/PC manufacturers missing from the catalog so
their monitors/laptops can be imported: ViewSonic, AOpen, AOC, Sceptre,
Planar, Alienware, Chuwi, Thermaltake, Colorful, Thomson, Elo,
Kensington, Targus, KOORUI, Pixio, INNOCN, InnoView, Lilliput.
verified:false, categorized pc-oem (Alienware sub-brand).

Refs #1
122 monitors unlocked by the new brand records — AOpen (70), ViewSonic,
Sceptre, KOORUI, AOC, Lilliput, Planar, InnoView, Alienware, Pixio,
INNOCN, Kensington. Same Amazon dataset (CC BY 4.0). verified:false.

Refs #1
16 laptops unlocked by the new brand records — Alienware (7), Thomson,
Chuwi, Colorful. abhinavflac dataset; cpu/gpu linked where matched.
verified:false.

Refs #1
Add the 18 new brands, 122 monitors and 16 laptops to the static v1
dump and bump the brand/laptop/monitor index and manifest counts
(brands 189->207, laptops 1935->1951, monitors 760->882). Regenerated
via app.dump @ bfdd4d9; only the new records + affected indexes.

Refs #1
@Seungpyo1007

Copy link
Copy Markdown
Member Author

🤖 Review — PASS

  • app.validate ✅ · integrity_check --strict ✅ · git diff --check ✅ · dump @ bfdd4d9 ✅ (108,522 records)
  • Added: 18 brands + 122 monitors + 16 laptops (all verified:false). Established brands only; obscure one-off Amazon sellers excluded. Alienware laptops carry cpu/gpu FKs.
  • Dump: surgical — new records + brand/laptop/monitor indexes + manifest only.

@Seungpyo1007 Seungpyo1007 merged commit b046ad3 into main Jul 8, 2026
5 checks passed
@Seungpyo1007 Seungpyo1007 moved this from In Progress to Done in TechAPI-Project Jul 8, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

Changed records in this PR

No records scored.

Full-dataset baseline

105689 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 10043
    "Yellow" : 93181
    "Red" : 2465
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 207 24 183 0 11.6%
soc 🟩🟨🟨🟨🟨🟥🟥🟥🟥🟥🟥🟥 2104 123 680 1301 5.8%
smartphone 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 93343 8453 83770 1120 9.1%
tablet 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 3455 174 3253 28 5.0%
watch 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 433 11 412 10 2.5%
pda 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 140 27 107 6 19.3%
gpu 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 2030 245 1785 0 12.1%
cpu 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨 3977 986 2991 0 24.8%
All 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 105689 10043 93181 2465 9.5%

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
python integrity_check.py TechAPI/data --strict PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

  • No data file changes detected.

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 207 10 197 0 207 4.8%
soc 2104 123 1981 0 2104 5.8%
smartphone 93343 8453 84890 0 93343 9.1%
tablet 3455 174 3281 0 3455 5.0%
watch 433 11 422 0 433 2.5%
pda 140 27 113 0 140 19.3%
gpu 2030 244 1786 0 2030 12.0%
cpu 3977 986 2991 0 3977 24.8%
all 105689 10028 95661 0 105689 9.5%

Warning

Tracked verified coverage is below 50% for watch 2.5% (11/433), brand 4.8% (10/207), tablet 5.0% (174/3455), soc 5.8% (123/2104), smartphone 9.1% (8453/93343), all 9.5% (10028/105689), gpu 12.0% (244/2030), pda 19.3% (27/140), and 1 more.
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py --strict
loaded CPU=3977 GPU=2030
✅ integrity gate: no hard anomalies.
Integrity section Flagged lines
structural 0
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 152
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Massive dataset rebuild: CPU + brand + GPU + smartphone + SoC (1989-2026)

2 participants