fix(site): list software and websites on the homepage - #139
Merged
Conversation
The endpoint list stopped at brands and never gained the collections added since: software, and websites (40,084 records, added this week). The playground resource picker was missing websites too, so the two newest collections were unreachable from the site even though the API serves them. Games are deliberately still absent: deploy-pages strips /v1/games from the published artifact (a million per-record files exceed the Pages deployment window), so listing them would hand visitors a 404. Also widens the meta description, which advertised only smartphone/SoC/GPU/CPU. Verified by building the site and grepping dist/index.html: v1/websites and v1/software render, games does not. Refs #1
Member
TechEngine change review: PASS
Changed data
Changed record examples
Heuristic review
Changed site
Modified site files
|
Member
TechEngine validation stats: PASS
Data summary
Warning Tracked verified coverage is below 50% for watch 2.5% (11/433), brand 4.8% (10/207), tablet 5.0% (174/3455), soc 5.8% (123/2104), smartphone 9.1% (8453/93396), all 9.5% (10028/105742), gpu 12.0% (244/2030), pda 19.3% (27/140), and 1 more. Validation notes
Key output:
Homepage build: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The homepage endpoint list ended at
/v1/brandsand never picked up the collections added since —software, andwebsites(40,084 records, merged this week). The playground's resource picker was missingwebsitesas well, so the two newest collections were invisible on the site even though the API serves them.+ /v1/software,+ /v1/websites+ websitesGames stay off the list on purpose
deploy-pagesstrips/v1/gamesfrom the published artifact — a million per-record files exceed the Pages deployment window — so listing games would send visitors to a 404. They remain versioned in the repo and served by the engine, just not from the static site.Verification
Built the site and grepped the output:
dist/index.htmlcontainsv1/websitesandv1/software/index.json, the picker has<option value="websites">, andvalue="games"appears 0 times — matching what deploy actually publishes.Refs #1
Closes #19