fix(verify): cap the per-host rate-limit backoff - #53
Merged
Conversation
The rate-limit penalty added in #52 is multiplicative with no ceiling, so a host that refuses repeatedly walks its interval up without bound (1s -> 4 -> 16 -> 64 -> ...). Over the ~4,000 cited GSMArena URLs that turns a run into hours of sleeping and risks the job timeout. Cap the per-host interval at 30s. Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #52. The backoff introduced there is multiplicative with no ceiling, so a host that refuses repeatedly walks its interval up without bound (1s -> 4 -> 16 -> 64 -> ...). A run over the ~4,000 cited GSMArena URLs could then spend hours asleep and blow the job timeout.
Caps the per-host interval at 30s, with a test that hammers
back_off20 times and asserts the ceiling holds.Refs #1