fix(verify): a missing GPU core count is a gap, not a contradiction - #57
Merged
Merged
Conversation
`vendor_core_field` failed whenever cuda_cores (nvidia) or stream_processors (amd/intel) was absent. Both are gpu RICH_FIELDS, so `completeness` already scores that absence — charging it again under `consistency` billed one gap twice, under a name that claims the record disagrees with itself. It also misread early hardware: the flagged records include the NV1, RIVA 128, RIVA TNT and GeForce 256, all of which predate the unified shader. A CUDA core count is inapplicable there, not missing. Of the 281 records carrying the flag, 279 have neither field set and 2 genuinely file the count under the other vendor's field. Only that second case is a contradiction, so only it still fails; an absence is now "na". Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vendor_core_fieldfails whenevercuda_cores(nvidia) orstream_processors(amd/intel) is absent. Both are already inRICH_FIELDS["gpu"], socompletenessscores that same absence — charging it again underconsistencybills one gap twice, under a name that says the record disagrees with itself.Splitting the 281 flagged records by what they actually contain:
The gaps are not even all gaps. They include the NV1, RIVA 128, RIVA TNT and GeForce 256 — parts that predate the unified shader, where a CUDA core count is inapplicable, not missing.
Change
passfail(a real mismatch; still soft)naThree regression tests cover the three branches;
tests/verifyis 56 passed.Effect
All 281 flagged records are yellow with
consistencyat exactly 23.3/35 (= 35 × 2/3 — one failure out of three evaluated signals). Dropping the false failure returns those ~11.7 points. 147 of them are in the near-miss band (T1/T2 host, score 65–74) and should cross the green threshold of 75; the rest are held back by other things.Found while looking for what remains between the near-miss pool and green: of 2,907 near-miss records, 1,926 need only 2 points. For smartphones that pool turned out to be unreachable — the missing rich fields (
charging_wired_w100%,os_version100%,cameras100%) have no in-record source, and every one of the 2,385 records lackingos_versioncarries a bareosstring with no version in it at all (Android,Windows Mobile,Feature phone,Symbian). The GPU pool is different: nothing needs to be sourced, the scoring was just wrong.Refs #1